View Issue Details

IDProjectCategoryView StatusLast Update
0000279Adventure PHP FrameworkCode-Verbesserung // Code improvementpublic2015-12-03 10:28
ReporterChristianAchatzAssigned ToChristianAchatz 
Status resolvedResolutionfixed 
Product Version3.1 
Target Version3.1Fixed in Version3.1 
Summary0000279: Form control creation should rely on interface definition rather than internal structure
DescriptionImplementation of method \APF\tools\form\taglib\HtmlFormTag::createFormElement() relates on the internal structure of the parent form control to create a new element within.

From a code design POV this is violating the method signature stating that the parent instance is of type DomNode which does not imply existence of field children.

For this reason, the implementation should be changed to rely on interface method getChildren() to add the new instance.
TagsNo tags attached.
Codereferenz: ([Datei]:[Zeile])tools/form/taglib/HtmlFormTag.php:216



2015-12-03 10:28

administrator   ~0000648

Code change thankfully contributed by Danil Mihajluk@PAYBACK.

Issue History

Date Modified Username Field Change
2015-12-03 08:23 ChristianAchatz New Issue
2015-12-03 08:23 ChristianAchatz Status new => assigned
2015-12-03 08:23 ChristianAchatz Assigned To => ChristianAchatz
2015-12-03 08:31 ChristianAchatz Status assigned => resolved
2015-12-03 08:31 ChristianAchatz Fixed in Version => 3.1
2015-12-03 08:31 ChristianAchatz Resolution open => fixed
2015-12-03 10:28 ChristianAchatz Note Added: 0000648